updating threat intelligence allowlist dynamic block #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for this PR I will get the tests running |
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matt-FFFFFF
approved these changes
Jun 6, 2024
|
We are preparing for the next major release, I will pull this into main and fix forward. |
anmolnagpal
pushed a commit
to clouddrove/terraform-azure-landingzone
that referenced
this pull request
Jul 8, 2024
* feat(connectivity): Add option to set allow_non_virtual_wan_traffic in express route gateway. (Azure#914) Co-authored-by: Miltos Tsatsakis <m.tsatsakis@kaizengaming.com> * updates to resolve issue Azure#794 (Azure#919) Co-authored-by: github-actions <action@github.com> * docs: update docs for threat_intelligence_allowlist (Azure#928) * Update wiki-sync.yml * chore(deps): bump github/super-linter from 5 to 6 (Azure#931) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add link to Upgrade guide from v4.2.0 to v5.0.0 (Azure#934) Co-authored-by: Matt White <16320656+matt-FFFFFF@users.noreply.github.com> * Added hub_routing_preference to connectivity advanced configuration (Azure#930) * Policy sync updates (Azure#959) * Update Library Templates (automated) (Azure#966) Co-authored-by: github-actions <action@github.com> * Add remote branch option (Azure#970) * Update Library Templates (automated) (Azure#973) Co-authored-by: github-actions <action@github.com> * Update Library Templates (automated) (Azure#976) Co-authored-by: github-actions <action@github.com> * Remove redundant assignment file (Azure#977) * updating threat intelligence allowlist dynamic block (Azure#953) Co-authored-by: Matt White <16320656+matt-FFFFFF@users.noreply.github.com> * chore(deps): bump azure/powershell from 1 to 2 (Azure#917) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add OpenSFF Scorecard (Azure#987) * chore(deps): bump github/codeql-action from 3.24.9 to 3.25.8 (Azure#990) * chore(deps): bump github.com/hashicorp/go-getter from 1.7.3 to 1.7.4 in /tests/terratest (Azure#986) * feat!: ama (Azure#968) * Fix example uami issue (Azure#1000) * Update Library Templates (automated) (Azure#1001) Co-authored-by: github-actions <action@github.com> * docs: additional v6 upgrade detail (Azure#1002) * Update Library Templates (automated) (Azure#1006) Co-authored-by: github-actions <action@github.com> * docs: update docs with FAQ on roadmap and banner for upcoming breaking changes (Azure#1008) * naming fixed in module --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Mtsa <miltsatsakis@gmail.com> Co-authored-by: Miltos Tsatsakis <m.tsatsakis@kaizengaming.com> Co-authored-by: Adam Tuckwell <106317528+ATuckwell@users.noreply.github.com> Co-authored-by: github-actions <action@github.com> Co-authored-by: Jared Holgate <jaredholgate@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tobias <tobias-m99@gmx.de> Co-authored-by: Matt White <16320656+matt-FFFFFF@users.noreply.github.com> Co-authored-by: QBY-MarkusMaring <106068259+QBY-MarkusMaring@users.noreply.github.com> Co-authored-by: cae-pr-creator[bot] <126156663+cae-pr-creator[bot]@users.noreply.github.com> Co-authored-by: Daan Toes <112694691+cndaan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Updating threat intelligence allowlist dynamic block for the hub spoke configuration. Copied the code from the vwan configuration, that seems to work.
This PR fixes/adds/changes/removes
Testing evidence
When adding the fqdns or ip_addresses inside the threat_intelligence_allowlist for the firewall resource,I get the following errors:
After the fix the values are added:
As part of this Pull Request I have
mainbranch