Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed SCM privatelink since it breaks DNS resolution #1097

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

egnirra
Copy link
Contributor

@egnirra egnirra commented Aug 22, 2024

Overview/Summary

The introduction of scm.privatelink.azurewebsites.net DNS zone breaks DNS resolution for the SCM endpoints.
Since by default it resolves via privatelink.azurewebsites.net already, there is no reason for the SCM zone to exist.

This PR fixes/adds/changes/removes

  1. v6.0.0 - introduction of the scm.privatelink.azurewebsites.net private dns zone appears to break DNS lookups for App Service kudu endpoint #1064

Breaking Changes

  1. It unbreaks this breaking change.

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

It's known to work, i don't want to break my env again just to prove it :)

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@matt-FFFFFF
Copy link
Member

/azp run unit

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matt-FFFFFF matt-FFFFFF merged commit e4850a2 into Azure:main Aug 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants