AVM-Review #9
Comments
|
@mbilalamjad Questions related to SFR5 variable "zones" {
type = set(string)
default = null
description = "(Optional) Specifies a list of Availability Zones in which this Kusto Cluster should be located. Changing this forces a new Kusto Cluster to be created."
validation {
condition = var.zones == null ? true : setunion(["1", "2", "3"], var.zones) == toset(["1", "2", "3"])
error_message = "Zones can be null or a combination of '1', '2' or '3'"
}
}to variable "zones" {
type = set(string)
default = ["1", "2", "3"]
description = "(Optional) Specifies a list of Availability Zones in which this Kusto Cluster should be located. Changing this forces a new Kusto Cluster to be created."
validation {
condition = var.zones == null ? true : setunion(["1", "2", "3"], var.zones) == toset(["1", "2", "3"])
error_message = "Zones can be null or a combination of '1', '2' or '3'"
}
} |
|
SFR2 mentions "Alignment SHOULD prioritize best-practices and security over cost optimization," Therefore I presume I should enable double encryption by default? variable "double_encryption_enabled" {
type = bool
default = null
description = "(Optional) Is the cluster's double encryption enabled? Changing this forces a new resource to be created."
}Also enable CMK by default? variable "customer_managed_key" {
type = object({
key_vault_resource_id = optional(string)
key_name = optional(string)
key_version = optional(string, null)
user_assigned_identity_resource_id = optional(string, null)
})
default = {}
description = "Customer managed keys that should be associated with the resource."
}and soft delete should be enabled by default to a value? Default in the provider is unlimited. variable "soft_delete_period" {
type = string
description = "(Optional) The time the data should be kept before it stops being accessible to queries as ISO 8601 timespan. Default is unlimited. For more information see: ISO 8601 Timespan."
default = null
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dear module owner,
As per the agreed module ownership requirements & responsibilities at the time of assignment, the AVM Team is opening this issue to request you to kindly review your module against the below AVM specs and confirm that they are met by the module. We appreciate if you don't close this issue till the review is complete. This review is required as a pre-req to be able to eventually publish the module as v1. AVM team would be happy to assist with the review and any questions that you might have around this.
Requested action is to complete below tasks and update the status column in the table below.
Tasks
The text was updated successfully, but these errors were encountered: