Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to azurermv4 #62

Merged
merged 2 commits into from
Jan 8, 2025
Merged

feat: update to azurermv4 #62

merged 2 commits into from
Jan 8, 2025

Conversation

jtracey93
Copy link
Contributor

Move to azurerm v4.0 minimum version

Fixes #60

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@jtracey93 jtracey93 requested a review from Copilot January 8, 2025 14:10
@jtracey93 jtracey93 changed the title Feat/update to azurermv4 feat: update to azurermv4 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • examples/custom-zones-vnet-link-existing-rg/main.tf: Language not supported
  • examples/default/main.tf: Language not supported
  • examples/with-vnet-link-existing-rg/main.tf: Language not supported
  • main.tf: Language not supported
  • terraform.tf: Language not supported
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jan 8, 2025
@jtracey93 jtracey93 added Type: Feature Request ➕ New feature or request Type: Hygiene 🧹 things related to testing, issue triage etc. and removed Needs: Triage 🔍 Maintainers need to triage still labels Jan 8, 2025
@jtracey93 jtracey93 merged commit 221d317 into main Jan 8, 2025
12 checks passed
@jtracey93 jtracey93 deleted the feat/update-to-azurermv4 branch January 8, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request ➕ New feature or request Type: Hygiene 🧹 things related to testing, issue triage etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Support for AzureRM >= 4.0
1 participant