Add support for nodepool's gpu_instance
#519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zioproto , would you please give this pr a review? Thanks! |
zioproto
requested changes
Mar 4, 2024
main.tf
Outdated
| @@ -59,6 +59,7 @@ resource "azurerm_kubernetes_cluster" "main" { | |||
| enable_host_encryption = var.enable_host_encryption | |||
| enable_node_public_ip = var.enable_node_public_ip | |||
| fips_enabled = var.default_node_pool_fips_enabled | |||
| gpu_instance = var.default_node_pool_gpu_instance | |||
There was a problem hiding this comment.
Why you would need GPUs in the system nodepool ?
variables.tf
Outdated
| @@ -436,6 +436,12 @@ variable "default_node_pool_fips_enabled" { | |||
| description = " (Optional) Should the nodes in this Node Pool have Federal Information Processing Standard enabled? Changing this forces a new resource to be created." | |||
| } | |||
|
|
|||
| variable "default_node_pool_gpu_instance" { | |||
There was a problem hiding this comment.
The default nodepool is a system node pool that contains also AKS system workloads. I don't see the value of adding a GPU workload on this nodepool.
I suggest to enable the GPU features only on the extra nodepools.
Why your use case needs a GPU on the system node pool ? Could you please share more about your scenario ? Thanks
…nce in system node pool
zioproto
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue number
#517
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!