Add web_app_routing_identity block to outputs #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zioproto
approved these changes
Nov 28, 2023
lonegunmanb
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Thanks @bonddim for opening this pr! Almost LGTM but two review comments.
outputs.tf
Outdated
|
|
||
| output "web_app_routing_identity" { | ||
| description = "The `azurerm_kubernetes_cluster`'s `web_app_routing_identity` block." | ||
| value = try(azurerm_kubernetes_cluster.main.web_app_routing[0].web_app_routing_identity, null) |
There was a problem hiding this comment.
According to the schema, web_app_routing_identity is a list of object, so I would recommend [] as default value instead of null, so the consumer can use for expression to iterate it:
value = try(azurerm_kubernetes_cluster.main.web_app_routing[0].web_app_routing_identity, [])Otherwise, we'll receive an error when we're using for expression and this output is null:
Error: Iteration over null value
outputs.tf
Outdated
| @@ -223,3 +223,8 @@ output "username" { | |||
| sensitive = true | |||
| value = azurerm_kubernetes_cluster.main.kube_config[0].username | |||
| } | |||
|
|
|||
| output "web_app_routing_identity" { | |||
| description = "The `azurerm_kubernetes_cluster`'s `web_app_routing_identity` block." | |||
There was a problem hiding this comment.
I'd like to address that this block is a list of object:
description = "The azurerm_kubernetes_cluster's web_app_routing_identity block, it's type is a list of object."
lonegunmanb
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This add
web_app_routing_identityto outputs, which is needed for role assignments when DNS zone and AKS Cluster are in different resource groups.Checklist before requesting a review
CHANGELOG.mdfile