Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for release 0.6.0 -> release 0.7.0 #358

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Fixes for release 0.6.0 -> release 0.7.0 #358

merged 10 commits into from
Feb 29, 2024

Conversation

nonik0
Copy link
Contributor

@nonik0 nonik0 commented Feb 23, 2024 •
edited
Loading

Description

Fixes for #356.

  • Update to .net8 to resolve nuget dependency issue with Azure.Identity and CG requirement
  • Update to latest Bicep version
  • Update to PSRule and related test updates and new test
  • Fixes for nuspec files, nuget files packed and sanity checked

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • Description of the pull request is clear and informative.
  • I have added myself to the 'assignees'.
  • I have added 'linked issues' if relevant.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nonik0 nonik0 self-assigned this Feb 23, 2024
@nonik0 nonik0 requested a review from a team as a code owner February 23, 2024 04:07
JohnathonMohr
JohnathonMohr approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@JohnathonMohr JohnathonMohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small suggestion.

src/Analyzer.PowerShellRuleEngine/PSRuleHostContext.cs Outdated Show resolved Hide resolved
@VeraBE VeraBE self-requested a review February 27, 2024 18:41
@nonik0 nonik0 force-pushed the psruleUpdate branch 2 times, most recently from c20b6d9 to 1265e65 Compare February 27, 2024 23:26
reynoldsa
reynoldsa approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@reynoldsa reynoldsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now that net8 is mentioned in the notes.

@nonik0 nonik0 changed the title Fixes for release 0.6.0 Fixes for release 0.6.0 -> release 0.7.0 Feb 29, 2024
@nonik0 nonik0 merged commit 582d919 into main Feb 29, 2024
5 checks passed
@nonik0 nonik0 deleted the psruleUpdate branch February 29, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnathonMohr JohnathonMohr JohnathonMohr approved these changes

@VeraBE VeraBE VeraBE approved these changes

@reynoldsa reynoldsa reynoldsa approved these changes

Assignees

@nonik0 nonik0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nonik0 @reynoldsa @VeraBE @JohnathonMohr