docs: Update README #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
craigshoemaker
commented
Feb 25, 2021
craigshoemaker
commented
- Clarify auth emulation port
- General text clean up
- Clarify auth emulation port - General text clean up
craigshoemaker
requested review from
annaji-msft,
anthonychu and
manekinekko
as code owners
manekinekko
reviewed
Feb 25, 2021
readme.md
Outdated
| When requesting `./auth/login/<provider>`, you will access a local authentication UI allowing you to set fake user information. | ||
| The CLI allows you to mock and read authentication & authorization credentials. | ||
|
|
||
| > **NOTE:** You must use port `4280` to access the authentication UI. |
There was a problem hiding this comment.
While 4280 is the default port, users may provide a different port using the --port option.
There was a problem hiding this comment.
I'll update the note to say that.
readme.md
Outdated
|
|
||
| When requesting `http://localhost:4280/.auth/login/<PROVIDER_NAME>`, you have access a local authentication UI allowing you to set fake user information. | ||
|
|
||
| Provider names available include: |
There was a problem hiding this comment.
User may also use their own auth providers
There was a problem hiding this comment.
okay - maybe just take this section out then?
craigshoemaker
commented
Feb 25, 2021
manekinekko
approved these changes
Feb 25, 2021
|
Thank you @craigshoemaker 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.