Use sanitizedUrl.search to format search params #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `matchingRewriteRouteQueryString` with `sanitizedUrl.search` to property format the search params
garand
requested review from
anthonychu,
manekinekko,
sgollapudi77 and
tkamesh
as code owners
garand
changed the title
github-actions
bot
added
the
scope: rules engine
2 tasks
|
@manekinekko Would be great to add a test for this. Do we have Cypress tests that test a dev server and not static? |
|
We don't. But we can update the static app to take into account fetching query params through JavaScript and making sure this implementation doesn't regress. cc @sgollapudi77 @Reshmi-Sriram |
manekinekko
approved these changes
Nov 23, 2021
I can create an open issue for testing this feature to work on and merge this PR now. |
Great idea. Let’s get this merged and released soon. Let me know if I can help. |
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue with this while setting up a Vite frontend (React template) with the SWA cli.
The change of adding
matchingRewriteRouteQueryStringto the end results in this:Notice the missing
?prefix.I instead replaced it with this:
if (doesMatchingRewriteRouteHaveQueryStringParameters) { - matchingRewriteRoutePath = sanitizedUrl.pathname + matchingRewriteRouteQueryString; // => /src/logo.svgimport= + matchingRewriteRoutePath = sanitizedUrl.pathname + sanitizedUrl.search; // => /src/logo.svg?import core_1.logger.silly(` - query: ${chalk_1.default.yellow(matchingRewriteRouteQueryString)}`); }The mapping is now correct.
And it correctly appends the search params and lets the Vite React starter load correctly.