fix: Correctly set x-ms-original-url to the full original request URL (#286)

[danielgary]

Resolves #286

Original issue:
In production, the x-ms-original-url header is set to the full, original request URL, so fallback functions can correctly handle every request. When using this CLI, x-ms-original-url was set to the rewrite path instead so functions could not tell what route they were supposed to be handling.

Here's what's changed:

• The x-ms-original-url is always set to the full, original request URL
• If x-ms-original-url is already set in injectHeaders, don't overwrite it
• getResponse now returns a boolean to indicate if the request was successfully handled or not
• If getResponse returns false, fall back to serveStaticOrProxyResponse

[danielgary]

Hi @anthonychu, this should resolve the issue with Remix running in dev and should correctly replicate how x-ms-original-url works in production.

[danielgary]

I refactored the getResponse method to return a boolean if it was succesfully handled.

I believe this is a better implementation than the previous one. Please let me know if any changes need to be made.

[manekinekko]

Thank you @danielgary for taking the time to investigate this issue. May I ask you to make two changes:

• add new unit tests and e2e tests to make sure we don't have any regression in the future.
• update your commit message based on our contributing guidelines.

[danielgary]

Thanks for the feedback @manekinekko

I've updated the message and also added an E2E test.

[danielgary]

Any updates on this? This is the only issue preventing Remix from including Azure SWA support out of the box.

[manekinekko]

I am sorry about the delay @danielgary, we were expecting to sync with other stakeholders on this change.

I am gonna skip team validation, and approve your changes to unblock you. We'd love to have the CLI support Remix based on your work.

Thank you again for your contribution 🎉

[danielgary]

Awesome! I already pinged the Remix team and I know they are looking forward to this being released!

[manekinekko]

Great! Looking forward to it ☺️

[garand]

@manekinekko Thanks for getting this merged in! Curious what your release cycle is and when we could expect a new release containing this change.

[sgollapudi77]

Hi @garand we're doing a release every month or so depending on the number of commits. So, following that we'll be doing a new release in less than a week. :)

[sgollapudi77]

Hi @garand we released a new version today with small fixes including the fix for this change. :D