Skip to content

Commit

Permalink
Merge pull request #250 from azure-javaee/fix_workflow_no_delete_bug
Browse files Browse the repository at this point in the history
Update workflow to remove unnecessary conditionals for deleting Azure resources.
  • Loading branch information
edburns authored Sep 13, 2024
2 parents 7cadea5 + 18b8d60 commit 70342f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/validate-byos-vmss.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ jobs:
echo "Sleeping for ${{ github.event.inputs.timeWaitBeforeDelete }}"
sleep ${{ github.event.inputs.timeWaitBeforeDelete }}
- name: Unregister before deleting resources
if: ${{ (github.event_name == 'workflow_dispatch' && inputs.deleteAzureResources) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
continue-on-error: true
uses: azure/CLI@v1
with:
Expand All @@ -332,7 +332,7 @@ jobs:
az vmss run-command invoke -g ${vmssResourceGroup} -n jbosseap-server${vmssName} --command-id RunShellScript --instance-id ${i} --scripts "sudo subscription-manager unregister"
done
- name: Delete Resource Group
if: ${{ (github.event_name == 'workflow_dispatch' && inputs.deleteAzureResources) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
id: delete-resource-group
run: |
echo "delete... " $vmssResourceGroup
Expand Down

0 comments on commit 70342f2

Please sign in to comment.