Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAV (sway) should report an error if discriminator is not required #386

Closed
sergey-shandar opened this issue Feb 5, 2019 · 2 comments
Closed

OAV (sway) should report an error if discriminator is not required #386

sergey-shandar opened this issue Feb 5, 2019 · 2 comments
Assignees
@raych1
Labels
P2 ramp-up-task

Comments

@sergey-shandar
Copy link
Contributor

No description provided.

@mozehgir
Copy link
Collaborator

Should be valid for all cases other than some edge cases like Cognitive Services who want to allow missing discrimantors.

@raych1 raych1 self-assigned this Jul 5, 2019
raych1 added a commit to raych1/oav that referenced this issue Jul 8, 2019
@raych1
Report error if 'discriminator' is not required
cf880e7 
Issue Azure#386 OAV report error if the property for 'discriminator' is not a
requried property.
@raych1 raych1 mentioned this issue Jul 8, 2019
Merged
raych1 added a commit that referenced this issue Jul 17, 2019
@raych1
Report error if 'discriminator' is not required (#439)
bcb532d 
* Report error if 'discriminator' is not required

Issue #386 OAV report error if the property for 'discriminator' is not a
requried property.

* Update error object.

* Add an unittest.

* Add suppression process for discriminator.

* Fix review comment and bump up package version.
@raych1
Copy link
Member

raych1 commented Jul 18, 2019

This issue was fixed.

@raych1 raych1 closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raych1 raych1

Labels
P2 ramp-up-task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sergey-shandar @raych1 @mozehgir