This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
Adds user assigned identity for web apps #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmazuel
reviewed
Feb 8, 2019
| "access_token": "AccessToken" | ||
| } | ||
| httpretty.register_uri(httpretty.GET, | ||
| 'http://127.0.0.1:41741/MSI/token/?resource=foo&api-version=2017-09-01&clientid=bar', |
There was a problem hiding this comment.
There is a discussion with Arturo right now that this will be changed to client_id. Do you have any insights?
There was a problem hiding this comment.
I sure don't, sorry - wasn't aware of those discussions
I would actually love to see this be made consistent with VM IMDS, and then we simplify everything to client_id everywhere. If/when this is resolved, please do share :)
I have an open PR on the .NET side that would need the same changes (Azure/azure-sdk-for-net#5181)
lmazuel
approved these changes
Feb 8, 2019
|
Hi @noelbundick |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for user-assigned managed identity on webapps by adding the
clientidparameter to the request made toMSI_ENDPOINTper the docsI've added tests and manually verified outside of this repo that this correctly acquires an access token on a Python Azure Function on App Service Plan
Other relevant info:
clientid, while for IMDS, it isclient_idmasterare broken - I'll rebase and update once master is green, just want to start the ball rolling on this