Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/config: Align flags names among commands #43

Merged
merged 1 commit into from
Jul 14, 2023
Merged

cmd/config: Align flags names among commands #43

merged 1 commit into from
Jul 14, 2023

Conversation

blanquicet
Copy link
Member

No description provided.

@blanquicet blanquicet requested a review from mqasimsarfraz July 14, 2023 10:29
@blanquicet blanquicet mentioned this pull request Jul 14, 2023
Merged
mqasimsarfraz
mqasimsarfraz approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mqasimsarfraz mqasimsarfraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please update integration test to use the same flag!

@blanquicet blanquicet force-pushed the jose/subscription-flag-name branch from 5d8520e to 8102bf2 Compare July 14, 2023 11:46
@blanquicet
cmd/config: Align flags names among commands
6af8a80 
Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
@blanquicet blanquicet force-pushed the jose/subscription-flag-name branch from 8102bf2 to 6af8a80 Compare July 14, 2023 13:04
@blanquicet blanquicet merged commit b504aa7 into main Jul 14, 2023
@blanquicet blanquicet deleted the jose/subscription-flag-name branch July 14, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mqasimsarfraz mqasimsarfraz mqasimsarfraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blanquicet @mqasimsarfraz