config: Support importing config using Azure API #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mqasimsarfraz
force-pushed
the
qasim/config-import-azure-api
branch
4 times, most recently
from
f3989d9 to
a9c816f
Compare
mqasimsarfraz
force-pushed
the
qasim/config-import-azure-api
branch
from
c084c94 to
c2968c0
Compare
blanquicet
reviewed
Jul 10, 2023
mqasimsarfraz
force-pushed
the
qasim/config-import-azure-api
branch
from
c2968c0 to
4391143
Compare
blanquicet
reviewed
Jul 11, 2023
cmd/utils/utils.go
Outdated
| "github.com/briandowns/spinner" | ||
| ) | ||
|
|
||
| var DefaultSpinner = spinner.New(spinner.CharSets[9], 50*time.Millisecond) |
There was a problem hiding this comment.
I agree I got bit aggressive with that 🙈 seems like they are using 200 ms frequency so I will switch to the same!
There was a problem hiding this comment.
Done. Feels much better! 😄
mqasimsarfraz
force-pushed
the
qasim/config-import-azure-api
branch
from
4391143 to
bf9e028
Compare
|
Thanks of the reviews! I will merge this one! |
|
I just realized that we didn't update the documentation with this alternative for |
Yeah, I opened a follow up PR with other improvement: https://github.com/Azure/kubectl-aks/pull/41/files I see that PR title isn't reflecting that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a fallback mechanism to import config in case Kubernetes API isn't available.
Fixes: #37
IAM changes
Since we will using Azure API to fetch config information, we will be needing new permission actions in subscription the cluster is running:
current:
Microsoft.Compute/virtualMachineScaleSets/virtualmachines/runCommand/actionnew
Microsoft.Compute/virtualMachineScaleSets/virtualmachines/runCommand/actionMicrosoft.Compute/virtualMachineScaleSets/virtualMachines/readMicrosoft.Compute/virtualMachineScaleSets/readTesting done
Added an integration tests and: