Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use Node 20 #83

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Update to use Node 20 #83

merged 1 commit into from
Feb 13, 2024

Conversation

Smilesc
Copy link
Contributor

@Smilesc Smilesc commented Jan 31, 2024

Update action.yml to use Node 20--there are now deprecation warnings for Node 16 on action runs:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: azure/k8s-set-context@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@Smilesc Smilesc requested a review from a team as a code owner January 31, 2024 00:09
@anfanik
Copy link

anfanik commented Feb 11, 2024

Merge please 🙏

davidgamero
davidgamero approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero
Copy link
Collaborator

@Smilesc you'll need to sign this commit to be able to merge

@Smilesc Smilesc force-pushed the main branch 2 times, most recently from cf741f8 to 6dc033a Compare February 13, 2024 07:51
@Smilesc
Copy link
Contributor Author

Smilesc commented Feb 13, 2024

@Smilesc you'll need to sign this commit to be able to merge

Thank you. Took a couple tries but I got it.

@davidgamero davidgamero merged commit f2d80c8 into Azure:main Feb 13, 2024
4 checks passed
@davidgamero
Copy link
Collaborator

thanks!

@camelpunch camelpunch mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiveerk jaiveerk jaiveerk approved these changes

@davidgamero davidgamero davidgamero approved these changes

@bfoley13 bfoley13 bfoley13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Smilesc @anfanik @davidgamero @bfoley13 @jaiveerk