Check for error from Azure when using the private-cluster feature #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the error check for Azure earlier, so that a well defined error is thrown on error instead of a JSONSyntax error. The issue is that when Azure returns an error, like when there's an issue with the access to the principal used. When this happens, the stdout field will be an empty string, and the error message will be set.
|
@microsoft-github-policy-service agree |
jaiveerk
previously approved these changes
Dec 8, 2022
OliverMKing
requested changes
Dec 12, 2022
|
This PR is idle because it has been open for 14 days with no activity. |
OliverMKing
approved these changes
Jan 3, 2023
|
Going to squash and merge this. Will kick off a release sometime soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the error check for Azure earlier, so that a well defined error is thrown on error instead of a JSONSyntax error.
The issue is that when Azure returns an error, like when there's an issue with the access to the principal used. When this happens, the stdout field will be an empty string, and the error message will be set to a non-json string.