Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get identity service version from source instead of tag #7280

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

damonbarry
Copy link
Member

@damonbarry damonbarry commented Apr 30, 2024

The Mariner arm64 build is currently failing. When it builds identity service bits, it tries to populate the version by getting the latest 1.5.* tag from the identity service repo. There are no 1.5.* tags yet, so it sends an empty version which causes make to fail.

The root cause is that we bumped our release version in code much sooner than we normally do (i.e., the period of time between bumping the version in code and actually publishing the bits is usually hours, but this time it's a couple weeks).

The fix is to extract the version from checked-in sources rather than git tag, since the tag isn't set until after we release.

To test, I ran the CI Build pipeline and confirmed that Mariner arm64 passes.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

yophilav
yophilav previously approved these changes Apr 30, 2024
@kodiakhq kodiakhq bot merged commit 7523e68 into Azure:main Apr 30, 2024
20 of 22 checks passed
@damonbarry damonbarry deleted the fix-mariner-arm64 branch April 30, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants