Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Release 1.2.7 #5976

Merged
merged 6 commits into from
Jan 12, 2022
Merged

Conversation

ggjjj
Copy link
Contributor

@ggjjj ggjjj commented Jan 11, 2022

Prepare for Release 1.2.7 with version update with changelog.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Draft PRs

  • Open the PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
edgelet/version.txt Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@ggjjj ggjjj marked this pull request as ready for review January 11, 2022 23:08
yophilav
yophilav previously approved these changes Jan 11, 2022
damonbarry
damonbarry previously approved these changes Jan 12, 2022
Copy link
Member

@damonbarry damonbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have a chance to look carefully at release notes, but we can always update that later if we find a problem. Otherwise looks good.

@ggjjj ggjjj dismissed stale reviews from damonbarry and yophilav via cfd1d71 January 12, 2022 00:15
Copy link
Contributor

@yophilav yophilav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke! 😄

@kodiakhq kodiakhq bot merged commit d3ec971 into Azure:release/1.2 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants