Edge Agent / Edge Hub: Bump prometheus versions to 4.2.0 #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and-rewsmith
changed the title
damonbarry
previously approved these changes
Aug 18, 2021
damonbarry
previously approved these changes
Aug 18, 2021
yophilav
previously approved these changes
Aug 18, 2021
damonbarry
previously approved these changes
Aug 18, 2021
This reverts commit d18cafd.
… into andsmi/1.1-fix-prom
damonbarry
reviewed
Aug 19, 2021
damonbarry
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to bump prometheus versions to avoid edge agent crash. Bumping this version means we have to split the edge util csproj into two. One that contains aspnet and one that doesn't. This is because the new prometheus dependency will fail fast and loud if aspnet framework isn't installed on the system. Seeing as how we use edge-util project in many different test modules which don't contain aspnet, the current setup will not work.