Update sysinfo package in iotedge CLI #4443
Conversation
|
The 0.14 upgrade was done in e9dc6c1 . Is that fix not needed for 1.1 ? (cc @lfitchett ) |
Well, it looks like Lee's commit fixed two different problems: (1) the hwmon-related crash (fixed by GuillaumeGomez/sysinfo@13a2249 and released in sysinfo 10.0, AFAICT), and (2) a problem with metrics that Lee mentioned in his commit description. Whether 1.1 needs the 2nd fix is not something we've talked about. But I believe upgrading to sysinfo 0.12.0 fixes the 1st problem. And it limits the scope of the change to iotedge CLI. |
Lee's commit that I linked to updated from 0.12 to 0.14. It fixes only the second problem. The first one was fixed by a different commit by Lee which updated from 0.9 to 0.12. I'm already aware of that commit, and it is the change you currently have in your PR. I'm asking if the Docker CPU fix is also needed for 1.1 or not, because if it is you should bump to 0.14 directly instead of 0.12 |
That's true for iotedged, but not iotedge CLI. I've been looking at this from the iotedge CLI angle.
You're right, I think the Docker CPU fix is needed since metrics is a critical feature for 1.1. Stay tuned... |
|
Oh right. The hwmon fix was also needed for |
|
Closing this PR in favor or #4444. |
This change upgrades the sysinfo package in the iotedge CLI to match the version used by iotedged. It fixes a bug called out in #2747.
Note that master branch is on a newer version of sysinfo (0.14.10). For 1.1 I'm choosing to bring iotedge to the same version (0.12.0) as iotedged to minimize churn--this change aligns sysinfo across both components without changing iotedged.