-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release1.0.10-rc1 #3137
Prepare release1.0.10-rc1 #3137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to create a custom list of important commits, not an actual list of all commits.
@@ -1,3 +1,66 @@ | |||
# 1.0.10-rc1 (2020-06-23) | |||
## Edge Agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varunpuranik please review this release note plus my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varunpuranik @philipktlin where did 1.0.9 changelog go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipktlin - which comments are you specifically referring to?
@massand - this one?
https://github.com/Azure/iotedge/blob/release/1.0.9/CHANGELOG.md#109-2020-03-18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varunpuranik all my comments are addressed. btw for 1.0.9 release, I think we should combine all changes in all 1.0.9 rc release notes into 1.0.9 release notes, what do you think?
…m/yophilav/iotedge into yophilav/prepareRelease1.0.10-rc1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added small comments
In 1.0.9-rc1 we changed the config.yaml for Windows to include 1.0.9-rc1 explicitly (4e0540b) The only caveat is that it must be removed for 1.0.10 real release |
I noticed that the links are not formatted properly for the 1.0.9-rc5 changelog. When we update the azure-iotedge repo we should fix these links: |
CHANGELOG.md
Outdated
@@ -1,3 +1,44 @@ | |||
# 1.0.10-rc1 (2020-06-25) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add start adding links to the release page in this changelog? Exactly like we do for our links from iotedge/release page to azure-iotedge/release page:
Head to the product release page for the changelog and IoT Edge daemon binaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would just be repeatedly copied for each release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can find a way to pin it to the top or something.
…m/yophilav/iotedge into yophilav/prepareRelease1.0.10-rc1
1.0.10-rc1 (2020-06-26)
Edge Agent
Features
Bug Fixes
Edge Hub
Features
Bug Fixes
iotedged
Features