Fix DeviceId collision in LH and Stress tests #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eIdCollisionLhNStress
philipktlin
reviewed
Jun 1, 2020
scripts/linux/runE2ETest.sh
Outdated
| @@ -698,7 +698,10 @@ function run_longhaul_test() { | |||
| print_highlighted_message "Run Long Haul test for $image_architecture_label" | |||
| test_setup | |||
|
|
|||
| local device_id="$RELEASE_LABEL-Linux-$image_architecture_label-longhaul" | |||
| # Import test-related functions | |||
| . $(dirname "$0")/testHelper.sh | |||
There was a problem hiding this comment.
testHelper.sh is not in the same folder as runE2ETest.sh in the iotedge repo. It is in the same folder only in the artifact. To simplify, just clone that method and put a TODO to share.
philipktlin
approved these changes
Jun 2, 2020
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 2, 2020
Update 1.0.9 to have unique device ID in LH and Stress tests Note: porting the changes from #3028 (master) to` release/1.0.9` branch
darobs
pushed a commit
to darobs/iotedge
that referenced
this pull request
Jun 30, 2020
) Update 1.0.9 to have unique device ID in LH and Stress tests Note: porting the changes from Azure#3028 (master) to` release/1.0.9` branch
darobs
added a commit
that referenced
this pull request
Jul 1, 2020
… put in master (#3166) * Update 1.0.9 to have unique device ID in LH and Stress tests (#3033) Update 1.0.9 to have unique device ID in LH and Stress tests Note: porting the changes from #3028 (master) to` release/1.0.9` branch * Phlin/edge agent get twin fix (#3075) When Edge agent calling GetTwinAsync method throws exception after retry policy, if the exception is not timeout exception it will trigger to close module client and retry again. * Upgrade Microsoft.Azure.Devices.Client from 1.23.1 to 1.23.2 (#3098) Upgrade Microsoft.Azure.Devices.Client NuGet package from 1.23.1 to 1.23.2, which contains AMQP Safely close fix. * Disable this test, same as what we did in master branch. (#3102) disable edge agent connection status test to fix CI build. This is already disabled in master branch and needs investigation from IoT hub team. * Allow environment variables to be empty or whitespace. (#2777) Environment variable values may be empty or whitespace. Docker allows these values for environment variable: "key1=" "key2= " * Add "(Kubernetes)" to ProductInfo. (#2811) * [k8s] Default Service protocol to "TCP" (#2929) If you create a module with Docker createOptions like so: ```json { "ExposedPorts":{ "35000":{} }, "HostConfig":{ "PortBindings":{ "35000":[{"HostPort":"35000"}] } } } ``` The Docker API will default the port to be "TCP". Therefore, the Docker->K8s translation should do the same. * [k8s] throw exception on watch error. (#2928) When we actually got an error from the watch, the watch stops and does not restart. Throw an error and let Agent recover from crash. * Fix unit test build. Co-authored-by: yophilav <54859653+yophilav@users.noreply.github.com> Co-authored-by: Philip Lin <philipktlin@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DeviceId collision in LH and Stress tests