Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UpstreamProtocol case insensitive #264

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Make UpstreamProtocol case insensitive #264

merged 3 commits into from
Sep 11, 2018

Conversation

varunpuranik
Copy link
Contributor

Fix a minor issue in EdgeHub to make UpstreamProtocol case insensitive.

myagley
myagley reviewed Sep 10, 2018
View reviewed changes
Copy link
Contributor

@myagley myagley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should/can we add a test to make sure this doesn't regress?

@varunpuranik
Copy link
Contributor Author

@myagley - Done

@myagley myagley closed this Sep 11, 2018
@myagley myagley reopened this Sep 11, 2018
@myagley myagley merged commit f48c780 into master Sep 11, 2018
@myagley myagley deleted the varunpuranik/fixUPcase branch September 11, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myagley myagley myagley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunpuranik @myagley