EdgeHub: Add option to turn off protocol heads #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myagley
approved these changes
Aug 15, 2018
| var protocolHeads = new List<IProtocolHead>(); | ||
| if (configuration.GetValue("mqttSettings:enabled", true)) | ||
| { | ||
| protocolHeads.Add(await container.Resolve<Task<MqttProtocolHead>>()); |
There was a problem hiding this comment.
This turned out really nice!
|
Curious - was this the cause of a leak? |
|
No, this just let's you run EdgeHub with a smaller memory footprint, something that some of the customers running edge on low power devices might want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config options to turn off one or more of the protocol heads. This is for customer using only one protocol head, and running on low power devices, so that they can reduce the memory used by EdgeHub.