-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics Support for EdgeHub (take #2) #1347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output of the metrics endpoint. Note that the dotnet metrics are added by the prometheus.net library by default, but seem useful.
|
myagley
requested changes
Jun 20, 2019
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.CloudProxy/CloudProxy.cs
Outdated
Show resolved
Hide resolved
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/device/DeviceMessageHandler.cs
Outdated
Show resolved
Hide resolved
edge-util/src/Microsoft.Azure.Devices.Edge.Util/metrics/IEdgeMetrics.cs
Outdated
Show resolved
Hide resolved
edge-util/src/Microsoft.Azure.Devices.Edge.Util/metrics/MetricsConstants.cs
Outdated
Show resolved
Hide resolved
edge-util/src/Microsoft.Azure.Devices.Edge.Util/metrics/MetricsConstants.cs
Outdated
Show resolved
Hide resolved
edge-util/src/Microsoft.Azure.Devices.Edge.Util/metrics/MetricsListener.cs
Show resolved
Hide resolved
edge-util/src/Microsoft.Azure.Devices.Edge.Util/metrics/appMetrics/MetricsTimer.cs
Show resolved
Hide resolved
edge-util/src/Microsoft.Azure.Devices.Edge.Util/metrics/prometheus.net/MetricsTimer.cs
Show resolved
Hide resolved
Lets definitely keep the default process level metrics. Lots of good stuff in there. |
…Proxy.cs Co-Authored-By: Mike Yagley <myagley@gmail.com>
…ceMessageHandler.cs Co-Authored-By: Mike Yagley <myagley@gmail.com>
…etrics.cs Co-Authored-By: Mike Yagley <myagley@gmail.com>
…sConstants.cs Co-Authored-By: Mike Yagley <myagley@gmail.com>
myagley
approved these changes
Jul 16, 2019
static readonly IMetricsHistogram MessagesProcessLatency = Util.Metrics.Metrics.Instance.CreateHistogram( | ||
"message_process_duration_milliseconds", | ||
static readonly IMetricsDuration MessagesProcessLatency = Util.Metrics.Metrics.Instance.CreateDuration( | ||
"message_process_duration", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message_process_duration_seconds
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Metrics support for EdgeHub #1290)
Sending out a separate PR since changes are significant.