Correctly close & dispose sdk client on fail to open (#7289)

From syncing with SDK team in regards to how disposal of SDK client is supposed to work, we need to make sure we call closeAsync and dispose. Relying on just dispose may not correctly clean up resources in all cases. ## Azure IoT Edge PR checklist:
Azure · Jun 20, 2024 · df2f019 · df2f019
1 parent 1f81779
commit df2f019
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/edge-hub/core/src/Microsoft.Azure.Devices.Edge.Hub.CloudProxy/DeviceClientWrapper.cs b/edge-hub/core/src/Microsoft.Azure.Devices.Edge.Hub.CloudProxy/DeviceClientWrapper.cs
@@ -54,8 +54,7 @@ public async Task OpenAsync()
             }
             catch (Exception)
             {
-                this.isActive.Set(false);
-                this.underlyingDeviceClient?.Dispose();
+                await this.CloseAsync();
                 throw;
             }
         }

diff --git a/edge-hub/core/src/Microsoft.Azure.Devices.Edge.Hub.CloudProxy/ModuleClientWrapper.cs b/edge-hub/core/src/Microsoft.Azure.Devices.Edge.Hub.CloudProxy/ModuleClientWrapper.cs
@@ -58,8 +58,7 @@ public async Task OpenAsync()
             }
             catch (Exception)
             {
-                this.isActive.Set(false);
-                this.underlyingModuleClient?.Dispose();
+                await this.CloseAsync();
                 throw;
             }
         }