Skip to content

Commit

Permalink
Remove potentially non-useful metrics from RQT (#3558)
Browse files Browse the repository at this point in the history
Don't collect 
* edgeAgent_created_pids_total
* edgeAgent_total_disk_read_bytes
* edgeAgent_total_disk_write_bytes
* edgeAgent_total_network_in_bytes
* edgeAgent_total_network_out_bytes
  • Loading branch information
lfitchett authored Sep 16, 2020
1 parent de9873e commit 14b928b
Showing 1 changed file with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -193,18 +193,20 @@ void SetModuleStats(SystemResources systemResources)
ms.PrivateWorkingSet.ForEach(mem => this.usedMemory.Set(mem, tags));
}
});
module.PidsStats.ForEach(ps => ps.Current.ForEach(current => this.createdPids.Set(current, tags)));

var tagsNoMsTelemetry = new string[] { name, false.ToString() };
module.PidsStats.ForEach(ps => ps.Current.ForEach(current => this.createdPids.Set(current, tagsNoMsTelemetry)));

module.Networks.ForEach(network =>
{
this.networkIn.Set(network.Sum(n => n.Value.RxBytes.OrDefault()), tags);
this.networkOut.Set(network.Sum(n => n.Value.TxBytes.OrDefault()), tags);
this.networkIn.Set(network.Sum(n => n.Value.RxBytes.OrDefault()), tagsNoMsTelemetry);
this.networkOut.Set(network.Sum(n => n.Value.TxBytes.OrDefault()), tagsNoMsTelemetry);
});

module.BlockIoStats.ForEach(disk =>
{
this.diskRead.Set(disk.Sum(io => io.Value.Where(d => d.Op.Exists(op => op == "Read")).Sum(d => d.Value.OrDefault())), tags);
this.diskWrite.Set(disk.Sum(io => io.Value.Where(d => d.Op.Exists(op => op == "Write")).Sum(d => d.Value.OrDefault())), tags);
this.diskRead.Set(disk.Sum(io => io.Value.Where(d => d.Op.Exists(op => op == "Read")).Sum(d => d.Value.OrDefault())), tagsNoMsTelemetry);
this.diskWrite.Set(disk.Sum(io => io.Value.Where(d => d.Op.Exists(op => op == "Write")).Sum(d => d.Value.OrDefault())), tagsNoMsTelemetry);
});
}
}
Expand Down

0 comments on commit 14b928b

Please sign in to comment.