Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AU915 RP1 frequencies #1939

Merged
merged 9 commits into from
Oct 28, 2022
Merged

Support AU915 RP1 frequencies #1939

merged 9 commits into from
Oct 28, 2022

Conversation

Mandur
Copy link
Contributor

@Mandur Mandur commented Oct 28, 2022

PR for issue #1730

done with the help of @ouphi

What is being addressed

Adding Australian frequencies to upstream

How is this addressed

  • Add Arduino Sample used to manually test (manually tested ABP, OTAA, C2D)
  • Add unit tests
  • Add implementation

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Merging #1939 (98259d1) into dev (441d483) will increase coverage by 0.27%.
The diff coverage is 98.92%.

@@            Coverage Diff             @@
##              dev    #1939      +/-   ##
==========================================
+ Coverage   87.48%   87.75%   +0.27%     
==========================================
  Files         250      250              
  Lines        9573     9542      -31     
==========================================
- Hits         8375     8374       -1     
+ Misses       1198     1168      -30     
Impacted Files Coverage Δ
...tworkSrvModule/LoraTools/Regions/RegionAU915RP1.cs 98.87% <98.87%> (ø)
...etworkSrvModule/LoraTools/Regions/RegionManager.cs 100.00% <100.00%> (ø)
...dule/LoraTools/IoTHubImpl/IoTHubRegistryManager.cs 75.00% <0.00%> (-22.57%) ⬇️
LoRaEngine/LoraKeysManagerFacade/FacadeStartup.cs 0.00% <0.00%> (ø)
...RaEngine/LoraKeysManagerFacade/CreateEdgeDevice.cs

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

private static readonly Region Region = RegionManager.AU915RP1;

public static readonly TheoryData<Region, Hertz, DataRateIndex, Hertz> TestRegionFrequencyDataDR0To5 =
TheoryDataFactory.From(from dr in new[] { DR0, DR1, DR2, DR3, DR4, DR5 }

Check warning

Code scanning / CodeQL

Useless assignment to local variable

This assignment to [dr](1) is useless, since its value is never read.
Comment on lines +19 to +32
from freq in new (double Input, double Output)[]
{
(915.2, 923.3),
(915.4, 923.9),
(915.6, 924.5),
(915.8, 925.1),
(916.0, 925.7),
(916.2, 926.3),
(916.4, 926.9),
(916.6, 927.5),
(916.8, 923.3),
(917.0, 923.9),
(917.2, 924.5),
}

Check warning

Code scanning / CodeQL

Useless assignment to local variable

This assignment to [freq](1) is useless, since its value is never read.
Comment on lines +36 to +46
TheoryDataFactory.From(from freq in new (Hertz Input, Hertz Output)[]
{
(Mega(915.9), Mega(923.3)),
(Mega(917.5), Mega(923.9)),
(Mega(919.1), Mega(924.5)),
(Mega(920.7), Mega(925.1)),
(Mega(922.3), Mega(925.7)),
(Mega(923.9), Mega(926.3)),
(Mega(925.5), Mega(926.9)),
(Mega(927.1), Mega(927.5)),
}

Check warning

Code scanning / CodeQL

Useless assignment to local variable

This assignment to [freq](1) is useless, since its value is never read.
{
get
{
au915RP1 ??= new RegionAU915RP1();

Check notice

Code scanning / CodeQL

Static field written by instance method

Write to static field from instance method or constructor.
@Mandur Mandur temporarily deployed to CI October 28, 2022 10:58 Inactive
@Mandur Mandur temporarily deployed to CI October 28, 2022 11:11 Inactive
@Mandur Mandur merged commit 5d5c3e6 into dev Oct 28, 2022
@Mandur Mandur deleted the feature/1912-au-freq branch October 28, 2022 11:25
ouphi added a commit to ouphi/iotedge-lorawan-starterkit that referenced this pull request Nov 2, 2022
* test

* Polish

* Set data rate in OTAA AU915 program.

* Renamed AU915RP1 to AU915.

* Changed data rate in ABP AU915 Arduino program.

* used DR5 for OTAA program + minor reformatting.

* Add the missing files

Co-authored-by: Ophelie Le Mentec <17216799+ouphi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants