-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AU915 RP1 frequencies #1939
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1939 +/- ##
==========================================
+ Coverage 87.48% 87.75% +0.27%
==========================================
Files 250 250
Lines 9573 9542 -31
==========================================
- Hits 8375 8374 -1
+ Misses 1198 1168 -30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
private static readonly Region Region = RegionManager.AU915RP1; | ||
|
||
public static readonly TheoryData<Region, Hertz, DataRateIndex, Hertz> TestRegionFrequencyDataDR0To5 = | ||
TheoryDataFactory.From(from dr in new[] { DR0, DR1, DR2, DR3, DR4, DR5 } |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
from freq in new (double Input, double Output)[] | ||
{ | ||
(915.2, 923.3), | ||
(915.4, 923.9), | ||
(915.6, 924.5), | ||
(915.8, 925.1), | ||
(916.0, 925.7), | ||
(916.2, 926.3), | ||
(916.4, 926.9), | ||
(916.6, 927.5), | ||
(916.8, 923.3), | ||
(917.0, 923.9), | ||
(917.2, 924.5), | ||
} |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
TheoryDataFactory.From(from freq in new (Hertz Input, Hertz Output)[] | ||
{ | ||
(Mega(915.9), Mega(923.3)), | ||
(Mega(917.5), Mega(923.9)), | ||
(Mega(919.1), Mega(924.5)), | ||
(Mega(920.7), Mega(925.1)), | ||
(Mega(922.3), Mega(925.7)), | ||
(Mega(923.9), Mega(926.3)), | ||
(Mega(925.5), Mega(926.9)), | ||
(Mega(927.1), Mega(927.5)), | ||
} |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
{ | ||
get | ||
{ | ||
au915RP1 ??= new RegionAU915RP1(); |
Check notice
Code scanning / CodeQL
Static field written by instance method
LoRaEngine/modules/LoRaWanNetworkSrvModule/LoRaWanNetworkSrvModule/Program.cs
Outdated
Show resolved
Hide resolved
LoRaEngine/modules/LoRaWanNetworkSrvModule/LoraTools/Regions/LoRaRegionType.cs
Show resolved
Hide resolved
* test * Polish * Set data rate in OTAA AU915 program. * Renamed AU915RP1 to AU915. * Changed data rate in ABP AU915 Arduino program. * used DR5 for OTAA program + minor reformatting. * Add the missing files Co-authored-by: Ophelie Le Mentec <17216799+ouphi@users.noreply.github.com>
PR for issue #1730
done with the help of @ouphi
What is being addressed
Adding Australian frequencies to upstream
How is this addressed