Don't use rx1droffset during join accept #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1729 +/- ##
=======================================
Coverage 86.58% 86.58%
=======================================
Files 236 236
Lines 9278 9279 +1
=======================================
+ Hits 8033 8034 +1
Misses 1245 1245
Continue to review full report at Codecov.
|
danigian
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #1727
What is being addressed
Don't use rx1droffset for the join accept message.
How is this addressed
As the Join accept message carries the settings for the end device, it is impossible that the setting is applied during the join procedure as the end device can't know about it.