Fix restart of the Basic Station Docker container #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1728 +/- ##
==========================================
+ Coverage 86.55% 86.58% +0.02%
==========================================
Files 236 236
Lines 9284 9278 -6
==========================================
- Hits 8036 8033 -3
+ Misses 1248 1245 -3
Continue to review full report at Codecov.
|
danigian
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix restart of the Basic Station Docker container
What is being addressed
When restarting the Basic Station module, it currently triggers the following issue:
The reason is that the startup script moves the file 'sx1301.station.conf'. When the container restarts, the startup script executes and fails as the file doesn't exist anymore at the source location.
How is this addressed
We change the move command to a copy command; this resolves the issue when deploying the branch and manually restarting the container we observe the following:
