Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused DevEUI that breaks deserialization #1711

Merged
merged 3 commits into from
May 19, 2022

Conversation

bastbu
Copy link
Collaborator

@bastbu bastbu commented May 18, 2022

Remove unused DevEUI that breaks deserialization

@bastbu bastbu added the fullci Run full continuous integration label May 18, 2022
@bastbu bastbu temporarily deployed to CI_AZURE_ENVIRONMENT May 18, 2022 18:55 Inactive
@bastbu bastbu temporarily deployed to CI_AZURE_ENVIRONMENT May 18, 2022 18:55 Inactive
@bastbu bastbu temporarily deployed to CI_ALL_IN_ONE_ARM_GATEWAY May 18, 2022 18:57 Inactive
@bastbu bastbu temporarily deployed to CI_CONCENTRATOR_EFLOW_ARM32 May 18, 2022 18:57 Inactive
@bastbu bastbu temporarily deployed to CI_EFLOW_AZURE_VM May 18, 2022 18:57 Inactive
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #1711 (67bc9cb) into dev (748bd1c) will increase coverage by 0.04%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##              dev    #1711      +/-   ##
==========================================
+ Coverage   86.53%   86.58%   +0.04%     
==========================================
  Files         236      236              
  Lines        9284     9278       -6     
==========================================
- Hits         8034     8033       -1     
+ Misses       1250     1245       -5     
Impacted Files Coverage Δ
...rkServer/FunctionBundler/PreferredGatewayResult.cs 100.00% <ø> (+11.11%) ⬆️
...kPreferredGateway/PreferredGatewayExecutionItem.cs 84.21% <50.00%> (+3.50%) ⬆️
...de/CheckPreferredGateway/PreferredGatewayResult.cs 66.66% <50.00%> (+4.76%) ⬆️
...NetworkServer/DefaultClassCDevicesMessageSender.cs 68.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748bd1c...67bc9cb. Read the comment docs.

@bastbu bastbu temporarily deployed to CI_AZURE_ENVIRONMENT May 18, 2022 19:00 Inactive
@github-actions github-actions bot added SensorDecodingTest Indicate SensorDecodingTest passed OTAAJoinTest Indicate OTAAJoinTest passed OTAATest Indicate OTAATest passed MacTest Indicate MacTest passed C2DMessageTest Indicate C2DMessageTest passed MultiGatewayTest Indicate MultiGatewayTest passed CupsTest labels May 18, 2022
@danigian danigian added the 1️⃣ Priority 1 (One) label May 18, 2022
@danigian danigian temporarily deployed to CI_AZURE_ENVIRONMENT May 18, 2022 21:16 Inactive
@danigian danigian temporarily deployed to CI_AZURE_ENVIRONMENT May 18, 2022 21:16 Inactive
@danigian danigian temporarily deployed to CI_CONCENTRATOR_EFLOW_ARM32 May 18, 2022 21:18 Inactive
@danigian danigian temporarily deployed to CI_ALL_IN_ONE_ARM_GATEWAY May 18, 2022 21:18 Inactive
@danigian danigian temporarily deployed to CI_EFLOW_AZURE_VM May 18, 2022 21:18 Inactive
@danigian danigian temporarily deployed to CI_AZURE_ENVIRONMENT May 18, 2022 21:26 Inactive
@github-actions github-actions bot added the ABPTest Indicate ABPTest passed label May 18, 2022
@bastbu bastbu added fullci Run full continuous integration and removed fullci Run full continuous integration labels May 19, 2022
@bastbu bastbu temporarily deployed to CI_AZURE_ENVIRONMENT May 19, 2022 15:33 Inactive
@bastbu bastbu temporarily deployed to CI_AZURE_ENVIRONMENT May 19, 2022 15:33 Inactive
@bastbu bastbu temporarily deployed to CI_ALL_IN_ONE_ARM_GATEWAY May 19, 2022 15:34 Inactive
@bastbu bastbu temporarily deployed to CI_EFLOW_AZURE_VM May 19, 2022 15:35 Inactive
@bastbu bastbu temporarily deployed to CI_CONCENTRATOR_EFLOW_ARM32 May 19, 2022 15:35 Inactive
@bastbu bastbu temporarily deployed to CI_AZURE_ENVIRONMENT May 19, 2022 15:38 Inactive
@bastbu bastbu temporarily deployed to CI_AZURE_ENVIRONMENT May 19, 2022 15:47 Inactive
@bastbu bastbu temporarily deployed to CI_AZURE_ENVIRONMENT May 19, 2022 15:47 Inactive
@bastbu bastbu temporarily deployed to CI_CONCENTRATOR_EFLOW_ARM32 May 19, 2022 15:48 Inactive
@bastbu bastbu temporarily deployed to CI_ALL_IN_ONE_ARM_GATEWAY May 19, 2022 15:48 Inactive
@bastbu bastbu temporarily deployed to CI_EFLOW_AZURE_VM May 19, 2022 15:48 Inactive
@bastbu bastbu temporarily deployed to CI_AZURE_ENVIRONMENT May 19, 2022 15:52 Inactive
@danigian danigian added the 2️⃣ Priority 2 (Two) label May 19, 2022
@danigian danigian temporarily deployed to CI_AZURE_ENVIRONMENT May 19, 2022 16:23 Inactive
@danigian danigian temporarily deployed to CI_AZURE_ENVIRONMENT May 19, 2022 16:23 Inactive
@danigian danigian temporarily deployed to CI_ALL_IN_ONE_ARM_GATEWAY May 19, 2022 16:25 Inactive
@danigian danigian temporarily deployed to CI_CONCENTRATOR_EFLOW_ARM32 May 19, 2022 16:25 Inactive
@danigian danigian temporarily deployed to CI_EFLOW_AZURE_VM May 19, 2022 16:25 Inactive
@danigian danigian temporarily deployed to CI_AZURE_ENVIRONMENT May 19, 2022 16:35 Inactive
@github-actions github-actions bot added the ClassCTest Indicate ClassCTest passed label May 19, 2022
@danigian danigian merged commit 648d339 into dev May 19, 2022
@danigian danigian deleted the bug/class-c-deserialization-failure branch May 19, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ Priority 1 (One) 2️⃣ Priority 2 (Two) ABPTest Indicate ABPTest passed C2DMessageTest Indicate C2DMessageTest passed ClassCTest Indicate ClassCTest passed CupsTest fullci Run full continuous integration MacTest Indicate MacTest passed MultiConcentratorTest MultiGatewayTest Indicate MultiGatewayTest passed OTAAJoinTest Indicate OTAAJoinTest passed OTAATest Indicate OTAATest passed SensorDecodingTest Indicate SensorDecodingTest passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants