Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent join request counting #1465

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Fix inconsistent join request counting #1465

merged 4 commits into from
Feb 7, 2022

Conversation

bastbu
Copy link
Collaborator

@bastbu bastbu commented Feb 7, 2022

What is being addressed

Before this PR, the join requests were counted in an inconsistent manner. After this PR, each join request is counted exactly once per gateway (independently of the deduplication strategy selected).

To validate this behavior we also add test infrastructure that can be used to unit test raising metrics.

@spygi spygi self-requested a review February 7, 2022 10:26
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #1465 (9ab6319) into dev (15ebf6e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1465      +/-   ##
==========================================
+ Coverage   84.86%   84.87%   +0.01%     
==========================================
  Files         226      226              
  Lines        8668     8675       +7     
==========================================
+ Hits         7356     7363       +7     
  Misses       1312     1312              
Impacted Files Coverage Δ
...sStation/Processors/LnsProtocolMessageProcessor.cs 84.39% <ø> (-0.11%) ⬇️
...LoRaWan.NetworkServer/JoinRequestMessageHandler.cs 89.10% <100.00%> (+0.14%) ⬆️
...kSrvModule/LoRaWan.NetworkServer/MetricRegistry.cs 100.00% <100.00%> (ø)
.../LoRaWan.NetworkServer/PrometheusMetricExporter.cs 85.00% <100.00%> (ø)
...le/LoRaWan.NetworkServer/RegistryMetricExporter.cs 94.02% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ebf6e...9ab6319. Read the comment docs.

Co-authored-by: Spyros Gi <spygi@users.noreply.github.com>
@bastbu bastbu merged commit d199060 into dev Feb 7, 2022
@bastbu bastbu deleted the bug/join-count-metric branch February 7, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants