Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all identity certs to create P-256 / RSA-2048 key pairs. #447

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix all identity certs to create P-256 / RSA-2048 key pairs. #447

wants to merge 1 commit into from

Conversation

arsing
Copy link
Member

@arsing arsing commented Aug 17, 2022

Fixes #403

gordonwang0
gordonwang0 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@gordonwang0 gordonwang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mariner builds failing are probably due to a keychain update in mariner. Damon's team is taking a look.

@arsing arsing marked this pull request as draft August 17, 2022 23:04
@arsing
Copy link
Member Author

arsing commented Aug 17, 2022

In shiproom we decided to do this after the next release branch is branched, and to implement a configuration option for this to reduce the chance of regression from switching from RSA to EC certs. So I've marked this is Draft for now.

@buentead
Copy link

I was wondering if there is an ETA for this PR to merge into main branch as I'm waiting for the fix of EST ID and Device ID certificates default to using different key types #403. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordonwang0 gordonwang0 gordonwang0 approved these changes

@onalante-msft onalante-msft onalante-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EST ID and Device ID certificates default to using different key types
4 participants
@arsing @buentead @gordonwang0 @onalante-msft