Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move system information gathering to common crate #342

Merged
merged 12 commits into from
Jan 18, 2022
Merged

Move system information gathering to common crate #342

merged 12 commits into from
Jan 18, 2022

Conversation

onalante-msft
Copy link
Contributor

edgelet uses the OsInfo, DmiInfo, and parse_shell_line functions.

arsing
arsing approved these changes Jan 4, 2022
View reviewed changes
aziotctl/aziotctl-common/src/host_info.rs Outdated Show resolved Hide resolved
aziotctl/Cargo.toml Outdated Show resolved Hide resolved
@onalante-msft
Remove unnecessary DMI variables
09d34ea 
Unnecessary with respect to product info specification.
@onalante-msft
Incorporate upstream PRs
28b5eb4 
- Parent directory creation
- Code coverage
- Documentation updates
@onalante-msft
Restrict serde versions
1909315 
serde_json for consistency, serde_with for safety.
@onalante-msft onalante-msft mentioned this pull request Jan 18, 2022
Merged
@kodiakhq kodiakhq bot merged commit 7abb09c into Azure:main Jan 18, 2022
kodiakhq bot pushed a commit that referenced this pull request Jan 20, 2022
@onalante-msft
[release/1.2] Move system information gathering to common crate (#353)
8acaa7a 
*Cf.* #342.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsing arsing arsing approved these changes

@gordonwang0 gordonwang0 gordonwang0 approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onalante-msft @arsing @gordonwang0