Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Configmap handling to deployments #419

Merged
merged 12 commits into from
Nov 8, 2024
Merged

Conversation

bfoley13
Copy link
Member

@bfoley13 bfoley13 commented Nov 6, 2024

Description

Adding configmap handling to deployment templates. This took moving the transformer logic from returning string to returning any to handle the json input -> yaml output smoothly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

  • Unit Test:
  • E2E Test:
  • Other Test: Tested generation/deployment with my own repo/cluster

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bfoley13 bfoley13 marked this pull request as ready for review November 8, 2024 15:40
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero enabled auto-merge (squash) November 8, 2024 20:03
@davidgamero davidgamero merged commit ea0fc31 into main Nov 8, 2024
149 checks passed
@davidgamero davidgamero deleted the brfole/template-updates branch November 8, 2024 20:03
@bfoley13 bfoley13 mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants