Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Template Enhancements #324

Merged
merged 54 commits into from
Jun 28, 2024

Conversation

meecethereese
Copy link
Contributor

@meecethereese meecethereese commented Jun 24, 2024

Description

This PR gets Draft's workflow templates up to par with DevHub's by including any missing environment arguments: workflowname, clusterresourcegroup, dockerfile, chartoverrides, and namespace. I also made some improvements to the ApplyDefaultVariables() function. Lastly, introduced the ability for a Draft user to now set their cluster to private within the template.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@meecethereese meecethereese force-pushed the workflow-template-enhancements branch from 28bf93d to 74e8783 Compare June 25, 2024 18:00
pkg/config/draftconfig.go Show resolved Hide resolved
pkg/config/draftconfig.go Show resolved Hide resolved
pkg/workflows/workflows.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can move this to outside the CreateWorkflowFiles function to avoid mixing these

pkg/config/draftconfig_test.go Outdated Show resolved Hide resolved
pkg/config/draftconfig.go Outdated Show resolved Hide resolved
@tbarnes94 tbarnes94 enabled auto-merge (squash) June 27, 2024 21:54
auto-merge was automatically disabled June 28, 2024 03:17

Pull request was closed

@meecethereese meecethereese reopened this Jun 28, 2024
@meecethereese meecethereese merged commit 96f500a into Azure:main Jun 28, 2024
149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants