-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow Template Enhancements #324
Merged
meecethereese
merged 54 commits into
Azure:main
from
meecethereese:workflow-template-enhancements
Jun 28, 2024
Merged
Workflow Template Enhancements #324
meecethereese
merged 54 commits into
Azure:main
from
meecethereese:workflow-template-enhancements
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eecethereese/draft-meece-copy into workflow-template-enhancements
meecethereese
force-pushed
the
workflow-template-enhancements
branch
from
June 25, 2024 18:00
28bf93d
to
74e8783
Compare
aamgayle
reviewed
Jun 25, 2024
Vidya2606
reviewed
Jun 25, 2024
davidgamero
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move this to outside the CreateWorkflowFiles function to avoid mixing these
This was referenced Jun 25, 2024
aamgayle
requested changes
Jun 26, 2024
aamgayle
approved these changes
Jun 26, 2024
tbarnes94
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gets Draft's workflow templates up to par with DevHub's by including any missing environment arguments: workflowname, clusterresourcegroup, dockerfile, chartoverrides, and namespace. I also made some improvements to the ApplyDefaultVariables() function. Lastly, introduced the ability for a Draft user to now set their cluster to private within the template.
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: