Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert docker build context flag and command line input to generate workflow #225

Merged

Conversation

davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Jul 31, 2023

Description

the -x command is not recognized by acr, and needs to be removed from the generated workflow in order to make valid github workflow files. In its current state, the workflow runs will always fail as this flag isn't recognized.

update call to updateProductionDeployments to use customInputs instead of flagValuesMap as it is a subset that was restricting command line input usage (all keys present in flagValuesMap are in customInputs due to the call to maps.Copy(customInputs, flagValuesMap))

add a nil map check for flagValuesMap

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@davidgamero davidgamero changed the title revert docker build context flag as it was breaking the workflow revert docker build context flag and command line input to generate workflow Aug 4, 2023
Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert looks good. Lets come back at this with some E2E tests using repos with a custom build context in the future

@davidgamero davidgamero merged commit 1357c89 into Azure:main Aug 7, 2023
@Tatsinnit Tatsinnit mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants