Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move generate-workflow to EmbeddedFS #194

Merged
merged 29 commits into from
Mar 24, 2023
Merged

Move generate-workflow to EmbeddedFS #194

merged 29 commits into from
Mar 24, 2023

Conversation

bosesuneha
Copy link
Member

@bosesuneha bosesuneha commented Mar 8, 2023 •
edited
Loading

Description

Moved the starterWorkflows embedded filesystem to use a portable embedded go package, added variable flag handling to generate-workflow command.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

davidgamero
davidgamero reviewed Mar 9, 2023
View reviewed changes
pkg/workflows/workflows.go Outdated Show resolved Hide resolved
pkg/workflows/workflows.go Outdated Show resolved Hide resolved
@bosesuneha bosesuneha requested a review from davidgamero March 9, 2023 20:31
davidgamero
davidgamero requested changes Mar 10, 2023
View reviewed changes
pkg/workflows/workflows.go Outdated Show resolved Hide resolved
davidgamero
davidgamero requested changes Mar 15, 2023
View reviewed changes
test/gen_integration.sh Outdated Show resolved Hide resolved
pkg/workflows/workflows_test.go Show resolved Hide resolved
pkg/workflows/workflows.go Show resolved Hide resolved
pkg/workflows/workflows.go Show resolved Hide resolved
@bosesuneha bosesuneha marked this pull request as draft March 22, 2023 02:04
@bosesuneha bosesuneha force-pushed the sunehabose/move-generateworkflow-to-embeddedfs branch from d00f69e to 2cf3c92 Compare March 22, 2023 03:16
@bosesuneha bosesuneha marked this pull request as ready for review March 22, 2023 03:33
davidgamero
davidgamero approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, you may need to sign some of the commits

bfoley13
bfoley13 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bosesuneha bosesuneha force-pushed the sunehabose/move-generateworkflow-to-embeddedfs branch 2 times, most recently from 8a5eded to 9e1f861 Compare March 24, 2023 18:11
@bosesuneha bosesuneha force-pushed the sunehabose/move-generateworkflow-to-embeddedfs branch from 9e1f861 to 77aa079 Compare March 24, 2023 18:23
@bosesuneha bosesuneha merged commit f50e4ca into main Mar 24, 2023
@bosesuneha bosesuneha deleted the sunehabose/move-generateworkflow-to-embeddedfs branch March 24, 2023 20:07
davidgamero pushed a commit to davidgamero/draft that referenced this pull request Mar 29, 2023
@bosesuneha @davidgamero
Move generate-workflow to EmbeddedFS (Azure#194)
3a12fe6
@davidgamero davidgamero mentioned this pull request Apr 10, 2023
Merged
aamgayle pushed a commit that referenced this pull request Apr 12, 2023
@bosesuneha @aamgayle
Move generate-workflow to EmbeddedFS (#194)
2eaa0ac
aamgayle pushed a commit that referenced this pull request Apr 12, 2023
@bosesuneha @aamgayle
Move generate-workflow to EmbeddedFS (#194)
fbdd0b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tatsinnit Tatsinnit Tatsinnit left review comments

@davidgamero davidgamero davidgamero approved these changes

@bfoley13 bfoley13 bfoley13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bosesuneha @bfoley13 @davidgamero @Tatsinnit