Fixing unintended update to GraphQL operation when updating REST methods

[severussundar]

Why make this change?

• Closes Updating rest methods leads to an update to grapql operations #1554

1. Creating a stored procedure entity with graphql configured for Query

Command: dab add getbooks --source "get_books" --source.type "stored-procedure" --permissions "anonymous:execute" --graphql.operation "query"
Config Json (just the entities section):

 "entities": {
    "getbooks": {
  "source": {
    "object": "get_books",
    "type": "stored-procedure",
    "parameters": null,
    "key-fields": null
  },
  "graphql": {
    "enabled": true,
    "operation": "query",
    "type": {
      "singular": "getbooks",
      "plural": "getbooks"
    }
  },
  "rest": {
    "enabled": true,
    "path": null,
    "methods": [
      "post"
    ]
  },
  "permissions": [
    {
      "role": "anonymous",
      "actions": [
        {
          "action": "execute",
          "fields": null,
          "policy": {
            "request": null,
            "database": null
          }
        }
      ]
    }
  ],
  "mappings": null,
  "relationships": null
}
  }

2. Update the rest method to GET
   Command: dab update getbooks --rest.methods "GET"

Config Json:

"entities": {
    "getbooks": {
  "source": {
    "object": "get_books",
    "type": "stored-procedure",
    "parameters": null,
    "key-fields": null
  },
  "graphql": {
    "enabled": true,
    "operation": "mutation",
    "type": {
      "singular": "getbooks",
      "plural": "getbooks"
    }
  },
  "rest": {
    "enabled": true,
    "path": null,
    "methods": [
      "get"
    ]
  },
  "permissions": [
    {
      "role": "anonymous",
      "actions": [
        {
          "action": "execute",
          "fields": null,
          "policy": {
            "request": null,
            "database": null
          }
        }
      ]
    }
  ],
  "mappings": null,
  "relationships": null
}
  }

When updating the rest.methods, the graphql operation has lost its original value of query. It now has the default value of mutation.

What is this change?

• ConfigGenerator.ConstructUpdatedGraphQLDetails(): When GraphQL operation is not updated, logic for preserving the existing configured graphQL operation is added
• EndToEndTests.TestUpdatingStoredProcedureWithRestMethods(): Adds a test case with the mentioned repro steps

How was this tested?

• Unit Tests
• Manual Tests

Sample Request(s)

• dab add getbooks --source "getbooks" --source.type "stored-procedure" --permissions "anonymous:execute" --graphql.operation "query"

 "entities": {
    "getbooks": {
  "source": {
    "object": "getbooks",
    "type": "stored-procedure",
    "parameters": null,
    "key-fields": null
  },
  "graphql": {
    "enabled": true,
    "operation": "query",
    "type": {
      "singular": "getbooks",
      "plural": "getbooks"
    }
  },
  "rest": {
    "enabled": true,
    "path": null,
    "methods": [
      "post"
    ]
  },
  "permissions": [
    {
      "role": "anonymous",
      "actions": [
        {
          "action": "execute",
          "fields": null,
          "policy": {
            "request": null,
            "database": null
          }
        }
      ]
    }
  ],
  "mappings": null,
  "relationships": null
}
  }

• dab update getbooks --rest.methods "get,patch"

 "entities": {
    "getbooks": {
  "source": {
    "object": "getbooks",
    "type": "stored-procedure",
    "parameters": null,
    "key-fields": null
  },
  "graphql": {
    "enabled": true,
    "operation": "query",
    "type": {
      "singular": "getbooks",
      "plural": "getbooks"
    }
  },
  "rest": {
    "enabled": true,
    "path": null,
    "methods": [
      "get",
      "patch"
    ]
  },
  "permissions": [
    {
      "role": "anonymous",
      "actions": [
        {
          "action": "execute",
          "fields": null,
          "policy": {
            "request": null,
            "database": null
          }
        }
      ]
    }
  ],
  "mappings": null,
  "relationships": null
}

The rest.methods field is updated with the right values and the existing value of graphql.operation is preserved

[aaronpowell]

Looks good. Waiting for the tests to pass.

I like that we have another Verify test in there!