-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nugetization refactor of DataApiBuilder #1539
Conversation
…or nugetization of dab that can be consumed by other projects.
… rohkhann/NugetSDKSupportDAB
…e/data-api-builder into rohkhann/NugetSDKSupportDAB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes. Could you also probably add basic design/block diagram of the proposed structure and how it is used? If you already have it in any other design doc, please link it here
src/Microsoft.DataApiBuilder.Service/AuthenticationHelpers/AppServiceAuthentication.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tidy ups proposed.
src/Azure.DataApiBuilder.Core/Authorization/AuthorizationResolver.cs
Outdated
Show resolved
Hide resolved
src/Azure.DataApiBuilder.Core/Authorization/AuthorizationResolver.cs
Outdated
Show resolved
Hide resolved
src/Azure.DataApiBuilder.Core/Configurations/RuntimeConfigValidator.cs
Outdated
Show resolved
Hide resolved
src/Azure.DataApiBuilder.Core/Configurations/RuntimeConfigValidator.cs
Outdated
Show resolved
Hide resolved
src/Service.Tests/Authentication/Helpers/WebHostBuilderHelper.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, left few rename suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor nit (can be ignored), otherwise good once tests pass.
Making class static Co-authored-by: Aaron Powell <me@aaron-powell.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one nit about now-unneeded code
…e/data-api-builder into rohkhann/NugetSDKSupportDAB
Why make this change?
This change is being made to allow nugetization of generic IP of Data api builder so that it can be consumed as a nuget by separate projects. There is no logic change or user experience change in this pr. It is a refactor of all the IP classes used by dab components into a separate c# library. Change has been internally discussed with DAB team as part of nugetization effort for DAB IP. This is an initial draft pr.
What is this change?
Created a new c# class library project that references auth and config projects. Moved all the folders from Service project to the new c# class project.
Pr is split into three commits for easier review:
Folders moved out of service to new project Azure.DataApiBuilder.Core:
New file created: Utils.cs in Core.
Service Old Folder Structure:

Service project New Folder Structure:

How was this tested?
Ran data api builder locally against mssql db
Ran unit tests listed on the contributions guidelines page
Sample Request(s)
No logic or workflow changes, just moving of files to a seperate project and reference changes
No logic or workflow changes, just moving of files to a seperate project and reference changes