Making the EntitySource.Type nullable #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it is a CosmosDB_NoSQL config, the entity 'type' is not important as there are no types in CosmosDB_NoSQL, so we don't want anything there. Combining this with #1529 will see the value removed from the config entirely
aaronpowell
requested review from
mbhaskar,
Aniruddh25,
JelteF,
seantleonard,
Mathos1432,
gledis69,
aaronburtle,
milismsft,
tarazou9,
ayush3797,
abhishekkumams,
severussundar and
ravishetye
as code owners
Aniruddh25
approved these changes
Jun 9, 2023
ayush3797
approved these changes
Jun 19, 2023
| "linking.target.fields": [] | ||
| } | ||
| } | ||
| "source": { |
There was a problem hiding this comment.
incorrect indentation
There was a problem hiding this comment.
probably no change is required in this file. maybe just revert the indentation change
There was a problem hiding this comment.
There are some minor stylistic changes and it seems very dependent on which formatter you use 😅
abhishekkumams
approved these changes
Jun 22, 2023
…fig-engine-null-entity-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it is a CosmosDB_NoSQL config, the entity 'type' is not important as there are no types in CosmosDB_NoSQL, so we don't want anything there.
Combining this with #1529 will see the value removed from the config entirely