fix: Use correct key for setting main build context #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signer implementation was not using standard docker keys for setting the main build context, this made it so you can't use signers as standalone frontends executing by `docker build`. This is a breaking change as anything implementing a signer will need to be updated to use the correct key. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
pmengelbert
force-pushed
the
pmengelbert/signer_context_key/1
branch
from
e660148 to
f68f5a6
Compare
cpuguy83
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpuguy83 - this is just a rebase of #368 . It took quite a bit of merge conflict handling, so please review carefully.
The signer implementation was not using standard docker keys for setting the main build context, this made it so you can't use signers as standalone frontends executing by
docker build.This is a breaking change as anything implementing a signer will need to be updated to use the correct key.
The main change here is
contextKey = "contextkey"instead ofcontextKey = "context".You can see this in the dockerui package in buildkit: https://github.com/moby/buildkit/blob/d8d946b85c52095d34a52ce210960832f4e06775/frontend/dockerui/context.go#L29
Other changes are just propagating progress groups around so signing is a little easier to track the status of in the build logs and then tests to ensure that the main context is indeed being set as expected.
supersedes #368