Keep RPM DB in mariner distroless images #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces parity in scanning Signed-off-by: Peter Engelbert <pengelbert@microsoft.com>
Signed-off-by: Peter Engelbert <pengelbert@microsoft.com>
It was checking for manifest files. We are no longer removing the manifest files, so the check now looks for the rpmdb. Signed-off-by: Peter Engelbert <pengelbert@microsoft.com>
cpuguy83
reviewed
Nov 8, 2024
| @@ -42,15 +42,12 @@ x-azl: &azl | |||
| - name: mariner rpm manifest files | |||
| files: | |||
| /var/lib/rpmmanifest/container-manifest-1: | |||
There was a problem hiding this comment.
I think we can remove these checks for the manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces parity in scanning
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: