windows: Add pinned deps and custom repo support #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperlin
reviewed
Oct 31, 2024
cpuguy83
force-pushed
the
windows_custom_repo
branch
from
2360e0f to
b2b28a1
Compare
adamperlin
requested changes
Oct 31, 2024
This is mostly copied from the jammy implementation since the windows target is currently using jammy as the build worker. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
gpg is a pretty big dependency, so we don't implicitly install this as part of the base worker image. This makes sure that in the cases where we do need to setup keys that gpg is actually installed. There's probably some room for optimization here, but I'll leave that for future work. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
windows_custom_repo
branch
from
b2b28a1 to
3bb990b
Compare
adamperlin
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly copied from the jammy implementation since the windows target is currently using jammy as the build worker.