Add support for allowing network access during build #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sozercan
reviewed
Oct 30, 2024
spec.go
Outdated
| @@ -401,6 +401,11 @@ type ArtifactBuild struct { | |||
| Steps []BuildStep `yaml:"steps" json:"steps" jsonschema:"required"` | |||
| // Env is the list of environment variables to set for all commands in this step group. | |||
| Env map[string]string `yaml:"env,omitempty" json:"env,omitempty"` | |||
|
|
|||
| // NetworkMode sets the network mode to use during the build phase. | |||
| // Accepted values: none, sandboxed | |||
There was a problem hiding this comment.
Suggested change
| // Accepted values: none, sandboxed | |
| // Accepted values: none, sandbox |
sozercan
reviewed
Oct 30, 2024
| func testBuildNetworkMode(ctx context.Context, t *testing.T, cfg targetConfig) { | ||
| type testCase struct { | ||
| mode string | ||
| canHazInternetz bool // :) |
sozercan
approved these changes
Oct 30, 2024
cpuguy83
force-pushed
the
allow_networking
branch
from
8f516fd to
2a81986
Compare
cpuguy83
force-pushed
the
allow_networking
branch
from
2a81986 to
8f5af16
Compare
Adds a field `network_mode`. The value of this field can be any of: - Unset - "none" - Disable networking (default) - "sandbox" - Networking enabled with its own network namespace Buildkit supports `host` mode as well, but I have opted to not support that here for now. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
allow_networking
branch
from
8f5af16 to
af5bc8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a field
network_mode. The value of this field can be any of:Buildkit supports
hostmode as well, but I have opted to not support that here for now.