add multi-module gen support #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing. src:
path: test/fixtures/multi-modules
context: {}
generate:
- gomod:
paths:
- module1
- module2
subpath: project |
cpuguy83
requested changes
Oct 14, 2024
|
Also looks like this needs a Otherwise this seems like its working. |
DannyBrito
force-pushed
the
dannybrito/multimodule
branch
from
b121157 to
bf7ce1c
Compare
cpuguy83
requested changes
Oct 18, 2024
generator_gomod.go
Outdated
| if g.Gomod.Paths == nil { | ||
| paths = []string{"."} | ||
| } | ||
| states := make([]llb.State, 0, len(paths)) |
There was a problem hiding this comment.
Since there can be duplicate modules that need to get downloaded, instead of using multiple states and merging them, can we build up a single state?
cpuguy83
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #392
Special notes for your reviewer: