deb: Disable dh_dwz which can cause issues for go #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperlin
approved these changes
Oct 11, 2024
|
Also affected by this. https://github.com/Azure/dalec-build-defs/actions/runs/11688802257/job/32550164925?pr=532 |
cpuguy83
force-pushed
the
disable_dwz
branch
4 times, most recently
from
e212d75 to
41692ce
Compare
This was not running CI when only template files were modified, which is undesirable. Instead of trying to include all the things we do want to run CI for, use path exclusions to filter out the things we don't want to run CI for. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
debbuild will automatically execute this `dh_dwz` target which, for some go builds, will error out like: 0.69 dwz: debian/msft-golang/usr/lib/msft-golang/bin/go: Found compressed .debug_abbrev section, not attempting dwz compression 40.69 dwz: debian/msft-golang/usr/lib/msft-golang/bin/gofmt: Found compressed .debug_abbrev section, not attempting dwz compression 40.69 dwz: Too few files for multifile optimization This does what dh_golang does and overrides this so the target doesn't do anything. We may want to make this opt-in in the future somehow (or scope it down to just go builds?). Not really sure what a good approach will be here, but for now this is blocking being able to build certain packages. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
Noticed that CI was not triggering on this due to filter rules in the github actions yaml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debbuild will automatically execute this
dh_dwztarget which, for some go builds, will error out like:This does what dh_golang does and overrides this so the target doesn't do anything.
We may want to make this opt-in in the future somehow (or scope it down to just go builds?).
Not really sure what a good approach will be here, but for now this is blocking being able to build certain packages.