Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizing git auth #386

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Support customizing git auth #386

merged 2 commits into from
Oct 3, 2024

Conversation

cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Oct 3, 2024

Allows the client to pass in custom git auth secrets.
Also documents the existing defaults that are used.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 requested a review from a team as a code owner October 3, 2024 18:01
@cpuguy83 cpuguy83 force-pushed the git_auths branch 2 times, most recently from d0cc886 to 3cd2e7d Compare October 3, 2024 18:05
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

By default git auth supports some default secret values for fetching
auth credentials (`GIT_AUTH_TOKEN` and `GIT_AUTH_HEADER`).
This change allows customizing that to different secret names.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83
Copy link
Member Author

cpuguy83 commented Oct 3, 2024

Made a minor doc string fixup (bad copy/paste)

@cpuguy83 cpuguy83 merged commit 4ec9a70 into Azure:main Oct 3, 2024
10 checks passed
@cpuguy83 cpuguy83 added this to the v0.9.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants