add initial support for SOURCE_DATE_EPOCH #175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds initial support for
SOURCE_DATE_EPOCH
, technically this variable was already able to be injected in Dalec specs as one of the requirements to add this is to explicit require theargs/envs
. It seems likeSOURCE_DATE_EPOCH
env var is auto injected by docker/buildx so no need to explicit--build-arg
. The difference I could notice is that now with change applied the build will not fail as unknow arg forSOURCE_DATE_EPOCH
var but it still requires the spec to set this variable to be used.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #54
Special notes for your reviewer: